-
-
Notifications
You must be signed in to change notification settings - Fork 488
Attemp to make compatible with full soc game for openxray #1940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Hello everyone! I'm new here, and I'm very intrigued by this PR I'm very far from C++, and unfortunately, I'm more familiar with Java :( I looked at the code and wanted to suggest implementing a common interface and then using it to implement resource handlers, like animation/sound and so on, depending on the game. If it is possible to implement it Here's the idea: During the game's initialization or launch, determine the game type and use it to call the necessary code The set and names of the methods/classes defining the contract are the same, but the implementation is specific to a given type of game It seems to me that this solution will simplify the code and reduce computational costs when checking conditions (I'm not sure that the branch predictor will always work correctly) UPD: Based on these considerations, I can suggest next ways to solve this issue:
|
e38d9d8 to
94d0261
Compare
interesting idea |
1 Attemp to make compatible with full soc game for openxray
Currently : A lot of bugs but runs